Skip to content

Update volume.py with volume of Icosahedron #9628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 16, 2023
Merged

Update volume.py with volume of Icosahedron #9628

merged 4 commits into from
Oct 16, 2023

Conversation

yousha806
Copy link
Contributor

@yousha806 yousha806 commented Oct 3, 2023 •
edited
Loading

Added function to find volume of a regular Icosahedron

Describe your change:

Added the functionality of finding the volume of a regular Icosahedron which is a convex polyhedron with 20 faces, 30 edges and 12 vertices. It is one of the five Platonic solids.

Wikipedia Reference: https://en.wikipedia.org/wiki/Regular_icosahedron

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@yousha806
Update volume.py with volume of Icosahedron
a6d302b 
Added function to find volume of a regular Icosahedron
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 3, 2023
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 3, 2023
tianyizheng02
tianyizheng02 approved these changes Oct 16, 2023
View reviewed changes
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 16, 2023
@tianyizheng02
Copy link
Contributor 

Expected:
    92.74068841203366
Got:
    92.74068841203365

Floating-point errors...

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 16, 2023
@tianyizheng02 tianyizheng02 merged commit cc0405d into TheAlgorithms:master Oct 16, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 16, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@yousha806 @pre-commit-ci
@tianyizheng02 @sedatguzelsemme
Update volume.py with volume of Icosahedron (TheAlgorithms#9628)
d39da71 
* Update volume.py with volume of Icosahedron

Added function to find volume of a regular Icosahedron

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

* Update volume.py

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tianyi Zheng <[email protected]>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yousha806 @tianyizheng02