Added fractionated_morse_cipher #9442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
ciphers/fractionated_morse_cipher.py
Outdated
| return decrypted_text | ||
|
|
||
|
|
||
| def main(): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file ciphers/fractionated_morse_cipher.py, please provide doctest for the function main
Please provide return type hint for the function: main. If the function does not return a value, please provide the type hint as: def function() -> None:
algorithms-keeper
bot
removed
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
ciphers/fractionated_morse_cipher.py
Outdated
| return decrypted_text | ||
|
|
||
|
|
||
| def main() -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file ciphers/fractionated_morse_cipher.py, please provide doctest for the function main
algorithms-keeper
bot
removed
the
require tests
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
|
@cclauss It would be great if you could review this! Kindly look into this pull request! It has already passed all the required tests! |
algorithms-keeper
bot
added
awaiting changes
Co-authored-by: Christian Clauss <[email protected]>
algorithms-keeper
bot
added
awaiting reviews
Co-authored-by: Christian Clauss <[email protected]>
…pact Co-authored-by: Christian Clauss <[email protected]>
|
Thank you for the valuable suggestions I will definitely keep this in mind for my further contributions! Learned a lot from this! Have committed thee suggested changes! |
|
Is there anything more i should add now? |
cclauss
approved these changes
Oct 8, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
|
Thank you! |
tianyizheng02
pushed a commit
to tianyizheng02/Python
that referenced
this pull request
Oct 8, 2023
* Added fractionated_morse_cipher * Added return type hint for main function * Added doctest for main * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Replaced main function * changed the references section Co-authored-by: Christian Clauss <[email protected]> * removed repetitive datatype hint in the docstring Co-authored-by: Christian Clauss <[email protected]> * changed dictionary comprehension variable names to something more compact Co-authored-by: Christian Clauss <[email protected]> * Update fractionated_morse_cipher.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <[email protected]>
sedatguzelsemme
pushed a commit
to sedatguzelsemme/Python
that referenced
this pull request
Sep 15, 2024
* Added fractionated_morse_cipher * Added return type hint for main function * Added doctest for main * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Replaced main function * changed the references section Co-authored-by: Christian Clauss <[email protected]> * removed repetitive datatype hint in the docstring Co-authored-by: Christian Clauss <[email protected]> * changed dictionary comprehension variable names to something more compact Co-authored-by: Christian Clauss <[email protected]> * Update fractionated_morse_cipher.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Added the Fractionated Morse Cipher implementation in Python an added the file
fractionated_morse_cipher.pyto theciphersdirectory. I have also added references to learn more about the cipher, docstrings for every function with an explanation and doctest.Checklist:
Fixes #9691