Adding the file of Fibonacci_Heap in DSA Section #9252
Conversation
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.parent = None | ||
|
|
||
| class FibonacciHeap: | ||
| def __init__(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| self.least = None | ||
| self.count = 0 | ||
|
|
||
| def insert(self, key): |
There was a problem hiding this comment.
Please provide return type hint for the function: insert. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function insert
Please provide type hint for the parameter: key
| if self.least is None or key < self.least.key: | ||
| self.least = new_node | ||
|
|
||
| def extract_min(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: extract_min. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function extract_min
|
|
||
| return min_node.key | ||
|
|
||
| def consolidate(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: consolidate. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function consolidate
|
|
||
| self.trees = new_trees | ||
|
|
||
| def decrease_key(self, node, new_key): |
There was a problem hiding this comment.
Please provide return type hint for the function: decrease_key. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function decrease_key
Please provide type hint for the parameter: node
Please provide type hint for the parameter: new_key
| self.cut(node) | ||
| self.cascading_cut(node.parent) | ||
|
|
||
| def cut(self, node): |
There was a problem hiding this comment.
Please provide return type hint for the function: cut. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function cut
Please provide type hint for the parameter: node
| node.degree = 0 | ||
| node.marked = False | ||
|
|
||
| def cascading_cut(self, node): |
There was a problem hiding this comment.
Please provide return type hint for the function: cascading_cut. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function cascading_cut
Please provide type hint for the parameter: node
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
class FibonacciNode:
def init(self, key: int):
self.key = key
self.children = []
self.marked = False
self.degree = 0
self.parent = None
class FibonacciHeap:
def init(self) -> None:
self.trees = []
self.least = None
self.count = 0
def insert(self, key: int) -> None:
new_node = FibonacciNode(key)
self.trees.append(new_node)
self.count += 1
if self.least is None or key < self.least.key:
self.least = new_node
def extract_min(self) -> int:
if self.count == 0:
raise ValueError("Heap is empty")
min_node = self.least
self.trees.remove(min_node)
for child in min_node.children:
child.parent = None
self.trees.append(child)
self.count -= 1
if self.least is min_node:
self.least = None
for node in self.trees:
if self.least is None or node.key < self.least.key:
self.least = node
self.consolidate()
return min_node.key
def consolidate(self) -> None:
degree_counts = [0] * len(self.trees)
for node in self.trees:
degree_counts[node.degree] += 1
new_trees = []
for i in range(len(degree_counts)):
while degree_counts[i] > 1:
degree_counts[i] -= 1
node1 = self.trees.pop()
node2 = self.trees.pop()
if node1.key < node2.key:
new_node = node1
new_node.children.append(node2)
else:
new_node = node2
new_node.children.append(node1)
new_node.degree += 1
new_trees.append(new_node)
self.trees = new_trees
def decrease_key(self, node: FibonacciNode, new_key: int) -> None:
if new_key > node.key:
raise ValueError("New key must be less than or equal to the old key")
node.key = new_key
if node == self.least:
self.least = node
while node.parent is not None and node.key < node.parent.key:
self.cut(node)
self.cascading_cut(node.parent)
def cut(self, node: FibonacciNode) -> None:
node.parent.children.remove(node)
node.parent = None
self.trees.append(node)
node.degree = 0
node.marked = False
def cascading_cut(self, node: FibonacciNode) -> None:
if node.marked:
self.cut(node)
if node.parent is not None:
node.parent.marked = True
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,99 @@ | |||
| class FibonacciNode: | |||
| def __init__(self, key): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: key
|
|
||
|
|
||
| class FibonacciHeap: | ||
| def __init__(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| self.least = None | ||
| self.count = 0 | ||
|
|
||
| def insert(self, key): |
There was a problem hiding this comment.
Please provide return type hint for the function: insert. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function insert
Please provide type hint for the parameter: key
| if self.least is None or key < self.least.key: | ||
| self.least = new_node | ||
|
|
||
| def extract_min(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: extract_min. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function extract_min
|
|
||
| return min_node.key | ||
|
|
||
| def consolidate(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: consolidate. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function consolidate
|
|
||
| self.trees = new_trees | ||
|
|
||
| def decrease_key(self, node, new_key): |
There was a problem hiding this comment.
Please provide return type hint for the function: decrease_key. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function decrease_key
Please provide type hint for the parameter: node
Please provide type hint for the parameter: new_key
| self.cut(node) | ||
| self.cascading_cut(node.parent) | ||
|
|
||
| def cut(self, node): |
There was a problem hiding this comment.
Please provide return type hint for the function: cut. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function cut
Please provide type hint for the parameter: node
| node.degree = 0 | ||
| node.marked = False | ||
|
|
||
| def cascading_cut(self, node): |
There was a problem hiding this comment.
Please provide return type hint for the function: cascading_cut. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function cascading_cut
Please provide type hint for the parameter: node
#8725
Describe your change:
Checklist: