Skip to content

fix: Making binary tree traversals lazy using generators #9214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: Making binary tree traversals lazy using generators #9214

wants to merge 1 commit into from

Conversation

dev-soni-07
Copy link

@dev-soni-07 dev-soni-07 commented Oct 1, 2023

Contribution Overview:

  • Created a new Python file minimum_platforms.py containing the Minimum Number of Platforms algorithm.
  • Included Python type hints for function parameters and return values.
  • Ensured the code adheres to the project's coding style and follows PEP 8 guidelines.
  • Ran doctests locally to verify correctness.

Additional Details:

  • The Minimum Number of Platforms algorithm is a fundamental problem in logistics and transportation scheduling.
  • The algorithm calculates the minimum number of platforms required to avoid delays and congestion in transportation systems.
  • Properly formatted the code using black for readability.
  • Included doctests to illustrate and verify the algorithm's correctness.
  • Tested locally using Python 3.11+ and mypy for type checking.

Related Issues:

Checklist:

  • Created the new file minimum_platforms.py.
  • Included Python type hints for function parameters and return values.
  • Formatted the code using black.
  • Ran doctests locally to verify correctness.

I'm excited to contribute to TheAlgorithms/Python and would appreciate your review and feedback. Please let me know if any further improvements are needed. Thank you!

@algorithms-keeper
Copy link

Closing this pull request as invalid

@digital-dev-07, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper bot closed this Oct 1, 2023
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Addition of Minimum Number of Platforms (Greedy Algorithm)
1 participant