Skip to content

Added minimum platforms required problem #9120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Siddharthrajrana
Copy link

Fixes #9119

Added a new problem based on the Greedy Algorithm: Minimum Platforms Required Problem.

Problem Description

Given arrival and departure times of all trains that reach a railway station. Find the minimum number of platforms required for the railway station so that no train is kept waiting.
Consider that all the trains arrive on the same day and leave on the same day. Arrival and departure time can never be the same for a train but we can have arrival time of one train equal to departure time of the other. At any given instance of time, same platform can not be used for both departure of a train and arrival of another train. In such cases, we need different platforms.

Input: n = 6
arr[] = {0900, 0940, 0950, 1100, 1500, 1800}
dep[] = {0910, 1200, 1120, 1130, 1900, 2000}

Output: 3
Explanation:
Minimum 3 platforms are required to
safely arrive and depart all trains.

Reference: https://practice.geeksforgeeks.org/problems/minimum-platforms-1587115620/1

Solution Approach

First we will sort both arrays. When there is sorted events, it will be easy to maintain
the count of trains that have arrived but not departed. The total platforms needed at one
time can be found by taking the difference between arrivals and departures at that time and
the maximum value of all times will be the final answer.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Sep 28, 2023
@rohan472000
Copy link
Contributor

Use ruff . --fix to rectify ruff issues.

@algorithms-keeper algorithms-keeper bot added the require type hints https://docs.python.org/3/library/typing.html label Sep 29, 2023
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

minimum will be the final answer.
"""

def minimum_platforms_required(arrival_times, departure_times):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: minimum_platforms_required. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: arrival_times

Please provide type hint for the parameter: departure_times

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Sep 29, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Sep 29, 2023
"""


def minimum_platforms_required(arrival_times, departure_times):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add return type of this fucntion.

int: Minimum number of platforms required.

Examples:
>>> minimum_platforms_required([900, 945, 955, 1100, 1500, 1800],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more edge and unique doctests.

@tianyizheng02
Copy link
Contributor

Thank you for your contribution, but unfortunately we're not accepting new PRs at the moment. We're currently trying to clear our backlog of existing PRs in preparation for Hacktoberfest. If you want to contribute, please wait until after October 1 to open a new PR.

@Siddharthrajrana Siddharthrajrana deleted the greedy_methods branch September 30, 2023 13:02
@Siddharthrajrana Siddharthrajrana restored the greedy_methods branch September 30, 2023 13:02
@Siddharthrajrana Siddharthrajrana deleted the greedy_methods branch September 30, 2023 13:02
@Siddharthrajrana Siddharthrajrana restored the greedy_methods branch September 30, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed require type hints https://docs.python.org/3/library/typing.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Addition of Minimum Number of Platforms (Greedy Algorithm)
3 participants