Skip to content

Updated basic_binary_tree.py #9092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

dasdebanna
Copy link

@dasdebanna dasdebanna commented Sep 26, 2023

The BinaryTree class has been created with the root node as its only argument. The utility functions have been modified to be methods of the BinaryTree class. The display, depth_of_tree, and is_full_binary_tree functions now take self as their first argument. The main function has been modified to create a BinaryTree object and call its methods instead of calling the utility functions directly.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes Additional Features for Binary Tree Implementation #8865 ".

dasdebanna and others added 2 commits September 26, 2023 18:37
The BinaryTree class has been created with the root node as its only argument. The utility functions have been modified to be methods of the BinaryTree class. The display, depth_of_tree, and is_full_binary_tree functions now take self as their first argument. The main function has been modified to create a BinaryTree object and call its methods instead of calling the utility functions directly.
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Sep 26, 2023
The BinaryTree class has been created with the root node as its only argument. The utility functions have been modified to be methods of the BinaryTree class. The display, depth_of_tree, and is_full_binary_tree functions now take self as their first argument. The main function has been modified to create a BinaryTree object and call its methods instead of calling the utility functions directly.
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Sep 26, 2023
@dasdebanna
Copy link
Author

Any maintainer please see the updated code and close this issue #8865

@rohan472000
Copy link
Contributor

In PR description, • [] should be replaced by •[x]

@dasdebanna
Copy link
Author

In PR description, • [] should be replaced by •[x]

I have changed the PR description

@tianyizheng02
Copy link
Contributor

Thank you for your contribution, but unfortunately we're not accepting new PRs at the moment. We're currently trying to clear our backlog of existing PRs in preparation for Hacktoberfest. If you want to contribute, please wait until after October 1 to do so. See this discussion for more info.

@dasdebanna
Copy link
Author

dasdebanna commented Sep 30, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional Features for Binary Tree Implementation
3 participants