Skip to content

Added a new algorithm of dividend discount model, and improved a document of price_plus_tax.py under the folder "financial"" #9071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Added a new algorithm of dividend discount model, and improved a document of price_plus_tax.py under the folder "financial"" #9071

wants to merge 10 commits into from

Conversation

Tongcai618
Copy link

Describe your change:

  • [yes] Add an algorithm?
  • [no] Fix a bug or typo in an existing algorithm?
  • [yes] Documentation change?

Checklist:

  • [yes] I have read CONTRIBUTING.md.
  • [yes] This pull request is all my own work -- I have not plagiarized.
  • [yes] I know that pull requests will not be merged if they fail the automated tests.
  • [ yes] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [yes ] All new Python files are placed inside an existing directory.
  • [yes] All filenames are in all lowercase characters with no spaces or dashes.
  • [yes ] All functions and variable names follow Python naming conventions.
  • [yes] All function parameters and return values are annotated with Python type hints.
  • [yes] All functions have doctests that pass the automated testing.
  • [yes] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • [yes] If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Tongcai618 and others added 4 commits September 18, 2023 21:02
@Tongcai618
Create dividend_discount_model.py
618c9ab 
This program is to pricing a company's stock using the value of next year dividend (D1), constant cost of equity capital (r), and constant growth rate in perpetuity (g).
@Tongcai618
Update dividend_discount_model.py
ab5526d
@Tongcai618
Update price_plus_tax.py
69cac1c 
I change the comment above to make the inputs more clear to read. Also, I add some conditions to prevent some situations that the price or tax rate is not legal.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
296755e 
for more information, see https://pre-commit.ci
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Sep 20, 2023
@rohan472000
Copy link
Contributor

rohan472000 commented Sep 23, 2023 •
edited
Loading

In PRs description, • [ ] should be replaced by • [x]

Also, build will pass now as #9078 is merged.

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Sep 30, 2023
@cclauss cclauss closed this Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tongcai618 @rohan472000 @cclauss @tianyizheng02