Skip to content

relu, sigmoid and tanh functions are shifted to neural networks #9065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

relu, sigmoid and tanh functions are shifted to neural networks #9065

wants to merge 1 commit into from

Conversation

ayu-g22
Copy link

@ayu-g22 ayu-g22 commented Sep 17, 2023 •
edited
Loading

Describe your change:

I moved the desired files to the given location.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Moved sigmoid, tanh and relu to neural_network/activation_functions from math/ #9050".

@ayu-g22
Copy link
Author

ayu-g22 commented Sep 17, 2023

Kindly review the changes.

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Sep 17, 2023
@rohan472000
Copy link
Contributor

Now build will pass as #9078 is merged.

@cclauss cclauss closed this Sep 30, 2023
@ayu-g22 ayu-g22 deleted the newBranch branch October 1, 2023 08:25
@ayu-g22 ayu-g22 restored the newBranch branch October 1, 2023 08:26
@ayu-g22 ayu-g22 deleted the newBranch branch October 1, 2023 08:26
@ayu-g22 ayu-g22 restored the newBranch branch October 1, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayu-g22 @rohan472000 @cclauss