Skip to content

Created octal_to_binary.py and fixed issue #8921 #8951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
77 changes: 77 additions & 0 deletions conversions/octal_to_binary.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
def octal_to_binary(octal: str) -> str:
"""
Convert an octal value to its binary equivalent
>>> octal_to_binary("")
Traceback (most recent call last):
...
ValueError: Empty string was passed to the function
>>> octal_to_binary("-")
Traceback (most recent call last):
...
ValueError: Non-octal value was passed to the function
>>> octal_to_binary("e")
Traceback (most recent call last):
...
ValueError: Non-octal value was passed to the function
>>> octal_to_binary(8)
Traceback (most recent call last):
...
ValueError: Non-octal value was passed to the function
>>> octal_to_binary("-e")
Traceback (most recent call last):
...
ValueError: Non-octal value was passed to the function
>>> octal_to_binary("-8")
Traceback (most recent call last):
...
ValueError: Non-octal value was passed to the function
>>> octal_to_binary("1")
'0b1'
>>> octal_to_binary("-1")
'-0b1'
>>> octal_to_binary("12")
'0b1010'
>>> octal_to_binary(" 12 ")
'0b1010'
>>> octal_to_binary("-45")
'-0b100101'
>>> octal_to_binary("-")
Traceback (most recent call last):
...
ValueError: Non-octal value was passed to the function
>>> octal_to_binary("0")
'0b0'
>>> octal_to_binary("-4055")
'-0b100000101101'
>>> octal_to_binary("2-0Fm")
Traceback (most recent call last):
...
ValueError: Non-octal value was passed to the function
>>> octal_to_binary("")
Traceback (most recent call last):
...
ValueError: Empty string was passed to the function
>>> octal_to_binary("19")
Traceback (most recent call last):
...
ValueError: Non-octal value was passed to the function
"""
oct_string = str(octal).strip()
if not oct_string:
raise ValueError("Empty string was passed to the function")
is_negative = oct_string.startswith("-")
if is_negative:
oct_string = oct_string[1:]
binary_num = "-0b"
else:
binary_num = "0b"
if not oct_string.isdigit() or not all(0 <= int(char) <= 7 for char in oct_string):
raise ValueError("Non-octal value was passed to the function")
binary_num += str(bin(int(oct_string, 8)))[2:]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still converting from octal to decimal to binary. int converts the input from octal to decimal, and bin converts that value from decimal to binary.

return binary_num


if __name__ == "__main__":
from doctest import testmod

testmod()