Created octal_to_binary.py and fixed issue #8921 #8951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ocatl_to_binary.py
for more information, see https://pre-commit.ci
Fixed whitespaces in blank lines.
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
for more information, see https://pre-commit.ci
Added type hints for the octal_to_binary function
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
conversions/octal_to_binary.py
Outdated
| @@ -0,0 +1,19 @@ | |||
| def octal_to_binary(octal)->int: | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file conversions/octal_to_binary.py, please provide doctest for the function octal_to_binary
Please provide type hint for the parameter: octal
for more information, see https://pre-commit.ci
Added all required type hints Added doctest
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
Fixed white spaces
algorithms-keeper
bot
removed
require tests
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
Made the code more efficient
for more information, see https://pre-commit.ci
| binary_num = "0b" | ||
| if not oct_string.isdigit() or not all(0 <= int(char) <= 7 for char in oct_string): | ||
| raise ValueError("Non-octal value was passed to the function") | ||
| binary_num += str(bin(int(oct_string, 8)))[2:] |
There was a problem hiding this comment.
This is still converting from octal to decimal to binary. int converts the input from octal to decimal, and bin converts that value from decimal to binary.
|
Closing in favor of #8949 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ocatl_to_binary.py
Describe your change:
Checklist: