Skip to content

Fix ruff rules ISC flake8-implicit-str-concat #8892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Jul 26, 2023

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jul 26, 2023
@cclauss cclauss changed the title Fix ruff rules ISC flake8-implicit-str-concat Fix ruff rules ISC flake8-implicit-str-concat -- DO NOT MERGE! Jul 26, 2023
@cclauss cclauss marked this pull request as draft July 26, 2023 07:13
@cclauss cclauss force-pushed the ruff-rule-ISC001 branch from 5e325ae to 8b9d1ae Compare July 26, 2023 10:33
@cclauss cclauss changed the title Fix ruff rules ISC flake8-implicit-str-concat -- DO NOT MERGE! Fix ruff rules ISC flake8-implicit-str-concat Jul 26, 2023
@cclauss cclauss marked this pull request as ready for review July 26, 2023 10:34
@cclauss cclauss requested review from a team and removed request for dhruvmanila July 27, 2023 07:40
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Jul 28, 2023
@poyea poyea merged commit dbaff34 into master Jul 28, 2023
@cclauss cclauss deleted the ruff-rule-ISC001 branch July 28, 2023 16:54
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants