Physics/basic orbital capture #8857
Conversation
…tAnorexic/Python into physics/basic_orbital_capture
for more information, see https://pre-commit.ci
…tAnorexic/Python into physics/basic_orbital_capture
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
for more information, see https://pre-commit.ci
…tAnorexic/Python into physics/basic_orbital_capture
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
I have implemented the doctests, and fixed codespell issues |
for more information, see https://pre-commit.ci
|
A little confused here. I understand where the test is failing, but this is not my file? Not even the same directory. Apologies, first time trying to contribute to something outside of my local scope. |
for more information, see https://pre-commit.ci
@FatAnorexic I believe the ruff errors are due to a different PR updating the kinds of errors that ruff checks for. It appears that every PR is failing because of ruff, so it's not anything wrong with your code. We kind of just have to wait for the ruff errors to be fixed. |
algorithms-keeper
bot
removed
the
tests are failing
There was a problem hiding this comment.
Please add doctests
See https://github.com/TheAlgorithms/Python/blob/master/physics/grahams_law.py for what doctests should look like
…tAnorexic/Python into physics/basic_orbital_capture
for more information, see https://pre-commit.ci
|
I added some scipy constants, and actually added doc tests. I apologize for failing to read through doctest documentation. Let me know if there's anything else you'd like me to do before final review. |
algorithms-keeper
bot
removed
the
tests are failing
algorithms-keeper
bot
removed
the
awaiting reviews
* Added file basic_orbital_capture * updating DIRECTORY.md * added second source * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fixed spelling errors * accepted changes * updating DIRECTORY.md * corrected spelling error * Added file basic_orbital_capture * added second source * fixed spelling errors * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * applied changes * reviewed and checked file * added doctest * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * removed redundant constnant * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added scipy imports * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added doctests to capture_radii and scipy const * fixed conflicts * finalizing file. Added tests * Update physics/basic_orbital_capture.py --------- Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <[email protected]>
Describe your change:
Adds two basic algorithms for capture/impact radii and capture area used in astronomy.
Checklist: