Skip to content

Enhancement/issue 8427 #8811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
43 changes: 43 additions & 0 deletions dynamic_programming/max_sub_array_sum.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
def max_sub_array_sum(arr: list[int], size: int) -> int:
"""
Finds the maximum sum of a subarray within the given array using Kadane's algorithm.

Args:
arr (list): The input array of numbers.
size (int): The size of the array.

Returns:
int: The maximum sum of a subarray within the array.

Example:
>>> arr = [-2, -3, 4, -1, -2, 5, -3]
>>> max_sub_array_sum(arr, len(arr))
6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a blank line to the tests pass.

Suggested change
6
6

As discussed in CONTRIBUTING.md please test your code by running on your local machine:
% python3 -m doctest -v dynamic_programming/max_sub_array_sum.py

In this example, the input array is [-2, -3, 4, -1, -2, 5, -3].
The maximum sum of a subarray within this array is 6,
which corresponds to the subarray [4, -1, -2, 5].

>>> arr = [-3, -4, 5, -1, 2, -4, 6, -1]
>>> max_sub_array_sum(arr, len(arr))
8

References:
https://en.wikipedia.org/wiki/Maximum_subarray_problem
"""
max_till_now = arr[0]
max_ending = 0

for i in range(size):
max_ending = max_ending + arr[i]
if max_ending < 0:
max_ending = 0
elif max_till_now < max_ending:
max_till_now = max_ending

return max_till_now


if __name__ == "__main__":
import doctest

doctest.testmod()
36 changes: 36 additions & 0 deletions other/sliding_window.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
def sliding_window(elements: list[int], window_size: int) -> list[list[int]]:
"""
Generate sliding windows of a specified size over a list of elements.

Args:
elements (list): The input list of elements.
window_size (int): The size of the sliding window.

Returns:
list: A list of sliding windows.

Example:
>>> lst = [1, 2, 3, 4, 5, 6, 7, 8]
>>> result = sliding_window(lst, 3)
>>> print(result)
[[1, 2, 3], [2, 3, 4], [3, 4, 5], [4, 5, 6], [5, 6, 7], [6, 7, 8]]

References:
https://stackoverflow.com/questions/8269916/what-is-sliding-window-algorithm-examples
"""

if len(elements) <= window_size:
return [elements]

windows = []
for i in range(len(elements) - window_size + 1):
window = elements[i : i + window_size]
windows.append(window)
Comment on lines +27 to +28
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
window = elements[i : i + window_size]
windows.append(window)
windows.append(elements[i : i + window_size])


return windows


if __name__ == "__main__":
import doctest

doctest.testmod()
37 changes: 37 additions & 0 deletions other/sliding_window_generators.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
from collections.abc import Generator


def sliding_window(
elements: list[int], window_size: int
) -> Generator[list[int], None, None]:
"""
Generate sliding windows of size window_size from the given elements.

Args:
elements (list): The input list of elements.
window_size (int): The size of the sliding window.

Returns:
generator: A generator that yields sublists of size window_size.

Example:
>>> lst = [1, 2, 3, 4, 5, 6, 7, 8]
>>> sw_gen = sliding_window(lst, 3)
>>> print(next(sw_gen))
[1, 2, 3]
>>> print(next(sw_gen))
Comment on lines +20 to +22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
>>> print(next(sw_gen))
[1, 2, 3]
>>> print(next(sw_gen))
>>> next(sw_gen)
[1, 2, 3]
>>> next(sw_gen)

[2, 3, 4]

References:
https://stackoverflow.com/questions/8269916/what-is-sliding-window-algorithm-examples
"""
if len(elements) <= window_size:
yield elements
for i in range(len(elements) - window_size + 1):
yield elements[i : i + window_size]


if __name__ == "__main__":
import doctest

doctest.testmod()