Skip to content

Create number container system algorithm #8808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 8, 2023

Conversation

CaedenPH
Copy link
Contributor

@CaedenPH CaedenPH commented Jun 7, 2023

Describe your change:

Implements a number container system algorithm which stores indexes and numbers at these corresponding indexes.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added require type hints https://docs.python.org/3/library/typing.html awaiting reviews This PR is ready to be reviewed labels Jun 7, 2023
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed require type hints https://docs.python.org/3/library/typing.html tests are failing Do not merge until tests pass labels Jun 7, 2023
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks cool!!

How does it perform on long lists of numbers?

from random import shuffle
numbers = list(range(10_000))
shuffle(numbers)
binary_search_delete(numbers, 5_000)

CaedenPH and others added 3 commits June 8, 2023 09:48
@github-actions github-actions bot force-pushed the create-number-container-system branch from 9bf70fe to 82e1a0b Compare June 8, 2023 08:50
@CaedenPH
Copy link
Contributor Author

CaedenPH commented Jun 8, 2023

This looks cool!!

How does it perform on long lists of numbers?


from random import shuffle

numbers = list(range(10_000))

shuffle(numbers)

binary_search_delete(numbers, 5_000)

Good idea, I can add some timeit methods to show the scalability of this algorithm.

Note that binary search requires a sorted array so shuffle cannot be used

@CaedenPH CaedenPH changed the title feat: Create number container system algorithm Create number container system algorithm Jun 8, 2023
@CaedenPH
Copy link
Contributor Author

CaedenPH commented Jun 8, 2023

@cclauss I have added more tests to both insert and delete functions along with allowing not only list of ints but also strings and range objects.
I'm not sure if implementing benchmarks is necessary because none of the search or sort algorithms have benchmarks unless they are being compared to other methods

@cclauss cclauss enabled auto-merge (squash) June 8, 2023 12:40
@cclauss cclauss merged commit 7775de0 into TheAlgorithms:master Jun 8, 2023
@CaedenPH CaedenPH deleted the create-number-container-system branch June 8, 2023 14:06
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
* feat: Create number container system algorithm

* updating DIRECTORY.md

* chore: Fix failing tests

* Update other/number_container_system.py

Co-authored-by: Christian Clauss <[email protected]>

* Update other/number_container_system.py

Co-authored-by: Christian Clauss <[email protected]>

* Update other/number_container_system.py

Co-authored-by: Christian Clauss <[email protected]>

* chore: Add more tests

* chore: Create binary_search_insert failing test

* type: Update typehints to accept str, list and range

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <[email protected]>
@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants