Skip to content

Mark fetch anime and play as broken #8763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 25, 2023
Merged

Mark fetch anime and play as broken #8763

merged 8 commits into from
May 25, 2023

Conversation

CaedenPH
Copy link
Contributor

Describe your change:

As shown in #8762 this algorithm is shown to be broken

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label May 24, 2023
@CaedenPH
Copy link
Contributor Author

@cclauss Merge to fix failing build tests

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label May 24, 2023
@CaedenPH CaedenPH requested a review from cclauss as a code owner May 24, 2023 21:34
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label May 24, 2023
@JadeKim042386 JadeKim042386 mentioned this pull request May 25, 2023
Merged
14 tasks
@cclauss cclauss enabled auto-merge (squash) May 25, 2023 05:57
cclauss
cclauss approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see how we can reenable this by using https://pypi.org/project/fake-useragent/ or some other technique to get around cloudflare.

@cclauss cclauss merged commit df88771 into TheAlgorithms:master May 25, 2023
@CaedenPH CaedenPH deleted the mark-fetch-anime-and-play-as-broken branch May 25, 2023 07:06
tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this pull request May 29, 2023
@CaedenPH @tianyizheng02
Mark fetch anime and play as broken (TheAlgorithms#8763)
73586e5 
* updating DIRECTORY.md

* updating DIRECTORY.md

* fix: Correct ruff errors

* fix: Mark anime algorithm as broken

* updating DIRECTORY.md

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@CaedenPH @sedatguzelsemme
Mark fetch anime and play as broken (TheAlgorithms#8763)
997f542 
* updating DIRECTORY.md

* updating DIRECTORY.md

* fix: Correct ruff errors

* fix: Mark anime algorithm as broken

* updating DIRECTORY.md

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CaedenPH @cclauss @tianyizheng02