Skip to content

Update evaluate_postfix_notations.py #8758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions data_structures/stacks/evaluate_postfix_notations.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ def evaluate_postfix(postfix_notation: list) -> int:
9
>>> evaluate_postfix(["4", "13", "5", "/", "+"])
6
>>> evaluate_postfix(["2", "+"])
2
>>> evaluate_postfix(["5", "-"])
-5
>>> evaluate_postfix([])
0
"""
Expand All @@ -28,17 +32,23 @@ def evaluate_postfix(postfix_notation: list) -> int:

for token in postfix_notation:
if token in operations:
b, a = stack.pop(), stack.pop()
if token == "+":
stack.append(a + b)
elif token == "-":
stack.append(a - b)
elif token == "*":
stack.append(a * b)
if token == "-" and len(stack) < 2:
operand = stack.pop()
stack.append(-operand)
elif (True) and len(stack) < 2:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elif (True) and len(stack) < 2 can be simplified to just len(stack) < 2.

operand = stack.pop()
stack.append(operand)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this elif block?

Copy link
Contributor Author

@rohan472000 rohan472000 Jun 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block will handle +,*,/ operators as above block(if block) is handling "-" operator.

else:
if a * b < 0 and a % b != 0:
stack.append(a // b + 1)
else:
b, a = stack.pop(), stack.pop()
if token == "+":
stack.append(a + b)
elif token == "-":
stack.append(a - b)
elif token == "*":
stack.append(a * b)
elif token == "/":
if b == 0:
raise ValueError("Invalid expression: division by zero")
stack.append(a // b)
else:
stack.append(int(token))
Expand Down