-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
Added an algorithm to calculate the present value of cash flows #8700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
39e901e
Added an algorithm to calculate the present value of cash flows
sahilg13 9fdb668
added doctest and reference
sahilg13 686b4bc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6b9a4f8
Resolving deprecation issues with typing module
sahilg13 582bd5e
Fixing argument type checks and adding doctest case
sahilg13 a01d5ac
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d025ce5
Fixing failing doctest case by requiring less precision due to floati…
sahilg13 7e86cab
Updating return type
sahilg13 39cc1f1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4d24720
Added test cases for more coverage
sahilg13 5e6c574
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 87f6947
Make improvements based on Rohan's suggestions
sahilg13 ae16f6e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c0afee8
Update financial/present_value.py
sahilg13 682b743
Update financial/present_value.py
sahilg13 0299cfb
Update financial/present_value.py
sahilg13 ae23ac6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0847eec
Apply suggestions from code review
cclauss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
""" | ||
Reference: https://www.investopedia.com/terms/p/presentvalue.asp | ||
An algorithm that calculates the present value of a stream of yearly cash flows given... | ||
1. The discount rate (as a decimal, not a percent) | ||
2. An array of cash flows, with the index of the cash flow being the associated year | ||
Note: This algorithm assumes that cash flows are paid at the end of the specified year | ||
def present_value(discount_rate: float, cash_flows: list[float]) -> float: | ||
""" | ||
>>> present_value(0.13, [10, 20.70, -293, 297]) | ||
4.69 | ||
>>> present_value(0.07, [-109129.39, 30923.23, 15098.93, 29734,39]) | ||
-42739.63 | ||
>>> present_value(0.07, [109129.39, 30923.23, 15098.93, 29734,39]) | ||
175519.15 | ||
>>> present_value(-1, [109129.39, 30923.23, 15098.93, 29734,39]) | ||
Traceback (most recent call last): | ||
... | ||
ValueError: Discount rate cannot be negative | ||
>>> present_value(0.03, []) | ||
Traceback (most recent call last): | ||
... | ||
ValueError: Cash flows list cannot be empty | ||
""" | ||
sahilg13 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if discount_rate < 0: | ||
raise ValueError("Discount rate cannot be negative") | ||
if not cash_flows: | ||
raise ValueError("Cash flows list cannot be empty") | ||
present_value = sum( | ||
cash_flow / ((1 + discount_rate) ** i) for i, cash_flow in enumerate(cash_flows) | ||
) | ||
return round(present_value, ndigits=2) | ||
|
||
sahilg13 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
if __name__ == "__main__": | ||
import doctest | ||
|
||
doctest.testmod() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An error occured while parsing the file:
financial/present_value.py