Skip to content

pre-commit: Update to mypy v1.0 #8124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

pre-commit: Update to mypy v1.0 #8124

wants to merge 1 commit into from
+2 −2

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Feb 7, 2023

Describe your change:

Mypy has finally reached v1.0.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss cclauss added the enhancement This PR modified some existing files label Feb 7, 2023
@cclauss cclauss requested a review from dhruvmanila as a code owner February 7, 2023 18:35
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Feb 7, 2023
@dhruvmanila
Copy link
Member

I think pre-commit automatically updates the versions periodically, right? Why are we doing this manually then?

@cclauss
Copy link
Member Author

cclauss commented Feb 8, 2023

Because this is an upgrade to v1.0 and I wanted to understand if there were breaking changes before I applied this upgrade to other repos that I work on.

@cclauss
Copy link
Member Author

cclauss commented Feb 13, 2023

Fixed in #8141

@cclauss cclauss closed this Feb 13, 2023
@cclauss cclauss deleted the mypy_v1.0 branch February 13, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @dhruvmanila