Add autoclave cipher #8029
Merged
Add autoclave cipher #8029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaedenPH
requested changes
Dec 14, 2022
ciphers/autoclave.py
Outdated
Comment on lines
6
to
12
| @params | ||
| plaintext - a normal text to be encrypted (string) | ||
| key - a small text or word to start the replacing (sFtring) | ||
|
|
||
| @return | ||
| A string with the ciphertext | ||
|
|
There was a problem hiding this comment.
Suggested change
| @params | |
| plaintext - a normal text to be encrypted (string) | |
| key - a small text or word to start the replacing (sFtring) | |
| @return | |
| A string with the ciphertext |
Typically, we want the parameter names to be self-documenting so this isn't really necessary
ciphers/autoclave.py
Outdated
Comment on lines
21
to
23
| if plaintext == "": | ||
| raise ValueError("plaintext is empty") | ||
| if key == "": |
There was a problem hiding this comment.
Suggested change
| if plaintext == "": | |
| raise ValueError("plaintext is empty") | |
| if key == "": | |
| if not plaintext: | |
| raise ValueError("plaintext is empty") | |
| if not key: |
ciphers/autoclave.py
Outdated
| if key == "": | ||
| raise ValueError("key is empty") | ||
|
|
||
| key = key + plaintext |
There was a problem hiding this comment.
Suggested change
| key = key + plaintext | |
| key += plaintext |
ciphers/autoclave.py
Outdated
| @@ -0,0 +1,111 @@ | |||
| def encrypt(plaintext, key) -> str: | |||
There was a problem hiding this comment.
Suggested change
| def encrypt(plaintext, key) -> str: | |
| def encrypt(plaintext, key) -> str: |
These parameters need to be typehinted
ciphers/autoclave.py
Outdated
Comment on lines
102
to
111
| operation = int(input("Type 1 to encrypt or 2 to decrypt:")) | ||
| if operation == 1: | ||
| plaintext = str(input("Typeplaintext to be encrypted:\n")) | ||
| key = str(input("Type the key:\n")) | ||
| print(encrypt(plaintext, key)) | ||
| elif operation == 2: | ||
| ciphertext = str(input("Type the ciphertext to be decrypted:\n")) | ||
| key = str(input("Type the key:\n")) | ||
| print(decrypt(ciphertext, key)) | ||
| decrypt("jsqqs avvwo", "coffee") |
There was a problem hiding this comment.
please move this into an if __name__ == "__main__": block
cclauss
reviewed
Dec 15, 2022
ciphers/autoclave.py
Outdated
| @@ -0,0 +1,111 @@ | |||
| def encrypt(plaintext, key) -> str: | |||
There was a problem hiding this comment.
Clave is Latin for key so the more popular name for this algorithm is autokey.
Suggested change
| def encrypt(plaintext, key) -> str: | |
| ””” | |
| https://en.wikipedia.org/wiki/Autokey_cipher | |
| > An autokey cipher (also known as the autoclave cipher) is a cipher that incorporates the message (the plaintext into the key. The key is generated from the message in some automated fashion, sometimes by selecting certain letters from the text or, more commonly, by adding a short primer key to the front of the message. | |
| ””” | |
| def encrypt(plaintext: str, key: str) -> str: |
cclauss
reviewed
Dec 15, 2022
ciphers/autoclave.py
Outdated
| >>> encrypt("hello world", "coffee") | ||
| 'jsqqs avvwo' | ||
| """ | ||
| if type(plaintext) != str: |
There was a problem hiding this comment.
PEP8: Use isinstance(plaintext, str) instead of directly comparing types.
for more information, see https://pre-commit.ci
cclauss
approved these changes
Dec 18, 2022
algorithms-keeper
bot
removed
the
awaiting reviews
algorithms-keeper
bot
removed
the
tests are failing
algorithms-keeper
bot
removed
the
awaiting reviews
Cjkjvfnby
pushed a commit
to Cjkjvfnby/Python
that referenced
this pull request
Mar 13, 2023
* Add autoclave cipher * Update autoclave with the given suggestions * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixing errors * Another fixes * Update and rename autoclave.py to autokey.py * Rename gaussian_naive_bayes.py to gaussian_naive_bayes.py.broken.txt * Rename gradient_boosting_regressor.py to gradient_boosting_regressor.py.broken.txt * Rename random_forest_classifier.py to random_forest_classifier.py.broken.txt * Rename random_forest_regressor.py to random_forest_regressor.py.broken.txt * Rename equal_loudness_filter.py to equal_loudness_filter.py.broken.txt Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
I'm adding the autoclave or autokey cipher.
Is similar to the vigenerè cipher, but using the own plaintext as the key.
The code implements an encrypt and a decrypt function.
For more info:
https://en.wikipedia.org/wiki/Autokey_cipher
Checklist:
Fixes: #{$ISSUE_NO}.