Skip to content

fix: mypy 0.991 issues #7988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Conversation

dhruvmanila
Copy link
Member

fixes: #7987

Note that matrix/matrix_class.py had CRLF line endings, that was converted to LF line endings and that's the major diff you're seeing. The actual diff is:

diff --git a/matrix/matrix_class.py b/matrix/matrix_class.py
index a73e8b92..2b4edc3c 100644
--- a/matrix/matrix_class.py
+++ b/matrix/matrix_class.py
@@ -345,7 +345,7 @@ class Matrix:
         if other == 0:
             return self.identity()
         if other < 0:
-            if self.is_invertable:
+            if self.is_invertable():
                 return self.inverse() ** (-other)
             raise ValueError(
                 "Only invertable matrices can be raised to a negative power"

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@dhruvmanila dhruvmanila requested a review from cclauss November 15, 2022 16:55
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Nov 15, 2022
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Nov 15, 2022
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but very odd diff's

@dhruvmanila
Copy link
Member Author

Looks good but very odd diff's

diff reason is specified in the PR description :)

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!!

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Nov 15, 2022
@cclauss cclauss merged commit 8bfd1c8 into TheAlgorithms:master Nov 15, 2022
Cjkjvfnby pushed a commit to Cjkjvfnby/Python that referenced this pull request Mar 13, 2023
* fix: mypy 0.991 issues

* fix: invalid condition for base case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixes required for new version of mypy #7983
3 participants