Reduce the complexity of graphs/minimum_spanning_tree_prims.py #7952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
enhancement
cclauss
reviewed
Nov 2, 2022
cclauss
reviewed
Nov 2, 2022
cclauss
reviewed
Nov 2, 2022
Comment on lines
88
to
91
| visited = [0 for i in range(len(adjacency_list))] | ||
| nbr_tv = [ | ||
| -1 for i in range(len(adjacency_list)) | ||
| ] # Neighboring Tree Vertex of selected vertex |
There was a problem hiding this comment.
Suggested change
| visited = [0 for i in range(len(adjacency_list))] | |
| nbr_tv = [ | |
| -1 for i in range(len(adjacency_list)) | |
| ] # Neighboring Tree Vertex of selected vertex | |
| visited = [0] * len(adjacency_list) | |
| nbr_tv = [-1] * len(adjacency_list) # Neighboring Tree Vertex of selected vertex |
cclauss
reviewed
Nov 2, 2022
Comment on lines
128
to
129
| n = int(input("Enter number of vertices: ").strip()) | ||
| e = int(input("Enter number of edges: ").strip()) |
There was a problem hiding this comment.
Do we gather this data and then not use it?
There was a problem hiding this comment.
Yes, n wasn't used, but e is used
cclauss
reviewed
Nov 2, 2022
Comment on lines
128
to
129
| n = int(input("Enter number of vertices: ").strip()) | ||
| e = int(input("Enter number of edges: ").strip()) |
There was a problem hiding this comment.
Suggested change
| n = int(input("Enter number of vertices: ").strip()) | |
| e = int(input("Enter number of edges: ").strip()) | |
| n = int(input("Enter number of vertices: ").strip()) | |
| number_of_edges = int(input("Enter number of edges: ").strip()) |
MaximSmolskiy
requested review from
cclauss
and removed request for
dhruvmanila
cclauss
approved these changes
Nov 2, 2022
algorithms-keeper
bot
removed
the
awaiting reviews
Yes |
MaximSmolskiy
deleted the
reduce-the-complexity-of-graphs/minimum_spanning_tree_prims.py
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Reduce the complexity of graphs/minimum_spanning_tree_prims.py from 21 to 7
Checklist:
Fixes: #{$ISSUE_NO}.