Reduce the complexity of linear_algebra/src/polynom_for_points.py

[MaximSmolskiy]

Describe your change:

Reduce the complexity of linear_algebra/src/polynom_for_points.py from 23 to 17

Fixes: #7942

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[cclauss]

Nice! https://www.scivision.dev/python-f-string-speed

[cclauss]

Awesome work! Other pull requests that further reduce our max-complexity would be warmly received.

[will472]

Unsubscribe

…

Sent from my iPhone

On Nov 2, 2022, at 2:25 PM, Christian Clauss ***@***.***> wrote:  @cclauss requested changes on this pull request. Nice! https://www.scivision.dev/python-f-string-speed In linear_algebra/src/polynom_for_points.py: > - if len(coordinates) == 1 and coordinates[0][0] == 0: - check = 2 - solved = "x=0" - except Exception: - check = 3 + set_x = {x for x, _ in coordinates} + if len(set_x) == 1: + return "x=" + str(coordinates[0][0]) Shorter, faster, and easier to read. ⬇️ Suggested change - return "x=" + str(coordinates[0][0]) + return f"x={coordinates[0][0]}" In linear_algebra/src/polynom_for_points.py: > - return solved + while count < x: + remove_e: list[str] = solution[count].split("E") + if len(remove_e) > 1: + solution[count] = remove_e[0] + "*10^" + remove_e[1] + solved += "x^" + str(x - (count + 1)) + "*" + str(solution[count]) ⬇️ Suggested change - solved += "x^" + str(x - (count + 1)) + "*" + str(solution[count]) + solved += f"x^{x - (count + 1)}*{solution[count]}" In linear_algebra/src/polynom_for_points.py: > - return solved + while count < x: + remove_e: list[str] = solution[count].split("E") + if len(remove_e) > 1: + solution[count] = remove_e[0] + "*10^" + remove_e[1] ⬇️ Suggested change - solution[count] = remove_e[0] + "*10^" + remove_e[1] + solution[count] = f"{remove_e[0]}*10^{remove_e[1]}" — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

[cclauss]

@will472 Please click the unsubscribe near the bottom of the right column of this page.