Skip to content

Adopt Python >= 3.8 assignment expressions using auto-walrus #7737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 28, 2022
Merged

Adopt Python >= 3.8 assignment expressions using auto-walrus #7737

merged 3 commits into from
Oct 28, 2022

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Oct 27, 2022

Describe your change:

Adopt Python >= 3.8 assignment expressions using https://pypi.org/project/auto-walrus/

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Fix continuous integration tests

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss cclauss requested a review from dhruvmanila as a code owner October 27, 2022 14:00
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 27, 2022
CaedenPH
CaedenPH approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition.
Whats with the diff in machine_learning/sequential_minimum_optimization.py?

@cclauss
Copy link
Member Author

cclauss commented Oct 27, 2022

No idea. Probably line endings or tabs, etc.

@MarcoGorelli
Copy link

MarcoGorelli commented Oct 28, 2022 •
edited
Loading

No idea. Probably line endings or tabs, etc.

Yeah I think it's just the line endings:

$ file machine_learning/sequential_minimum_optimization.py 
machine_learning/sequential_minimum_optimization.py: Python script, ASCII text executable, with CRLF line terminators

dhruvmanila
dhruvmanila approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for walrus! ;)

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 28, 2022
@cclauss cclauss merged commit 19bff00 into TheAlgorithms:master Oct 28, 2022
@cclauss cclauss deleted the auto-walrus branch October 28, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedenPH CaedenPH CaedenPH approved these changes

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cclauss @MarcoGorelli @CaedenPH @dhruvmanila