Create largest_square_area_in_matrix.py #7673
Conversation
algorithms-keeper
bot
added
the
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| 0 | ||
| """ | ||
|
|
||
| def update_area_of_max_square(row: int, col: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square
| >>> largest_square_area_in_matrix_top_down_approch_with_dp(2, 2, [[0,0], [0,0]]) | ||
| 0 | ||
| """ | ||
| def update_area_of_max_square_using_dp_array(row: int, col: int, dp_array: List[List[int]]) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square_using_dp_array
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| 0 | ||
| """ | ||
|
|
||
| def update_area_of_max_square(row: int, col: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square
| 0 | ||
| """ | ||
|
|
||
| def update_area_of_max_square_using_dp_array( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square_using_dp_array
Co-authored-by: Caeden Perelli-Harris <[email protected]>
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| 0 | ||
| """ | ||
|
|
||
| def update_area_of_max_square(row: int, col: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square
| 0 | ||
| """ | ||
|
|
||
| def update_area_of_max_square_using_dp_array( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square_using_dp_array
Co-authored-by: Caeden Perelli-Harris <[email protected]>
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| 0 | ||
| """ | ||
|
|
||
| def update_area_of_max_square(row: int, col: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square
| 0 | ||
| """ | ||
|
|
||
| def update_area_of_max_square_using_dp_array( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square_using_dp_array
algorithms-keeper
bot
added
tests are failing
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| 0 | ||
| """ | ||
|
|
||
| def update_area_of_max_square(row: int, col: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square
| 0 | ||
| """ | ||
|
|
||
| def update_area_of_max_square_using_dp_array( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square_using_dp_array
|
Is there a function missing doctests? Click |
|
Actually the for recursive code, inside a parent function |
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| 0 | ||
| """ | ||
|
|
||
| def update_area_of_max_square(row: int, col: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square
| 0 | ||
| """ | ||
|
|
||
| def update_area_of_max_square_using_dp_array( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square_using_dp_array
|
Cool. Doctests do not run in functions that are nested under other functions so we can ignore the keeperbot on that one. |
|
@cclauss, Misspelled words and maxline error took in consideration and done necessary changes |
algorithms-keeper
bot
removed
the
awaiting reviews
cclauss
added
hacktoberfest
hacktoberfest-accepted
Describe your change:
Added my approach for following question
Question:
Given a binary matrix mat of size n * m, find out the maximum size square
sub-matrix with all 1s.
Example 1:
Input:
n = 2, m = 2
mat = [[1, 1],
[1, 1]]
Output:
2
Checklist:
Fixes: #{$ISSUE_NO}.