-
-
Notifications
You must be signed in to change notification settings - Fork 46.7k
ci: Consolidate requirements into pyproject.toml
#7565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@cclauss Never used pyproject.toml, so expecting lots of changes |
We could also move our codespell, mypy, and pyupgrade args from .pre-commit into pyproject.toml. Please run https://pypi.org/project/validate-pyproject to validate the file and let's add that tool to pre-commit. |
How would this be done? |
Co-authored-by: Christian Clauss <[email protected]>
The only benefit we get in using Build system is used to provide a backend like poetry, flit or setuptools to actually build the Python package (wheels). For our use case, |
Let's use Would we be able to use Could |
As I said, this won't work as |
I fail to understand the logic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I must've misunderstood something, if it works then it's fine @cclauss
Co-authored-by: Dhruv Manilawala <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
"requests", | ||
"rich", | ||
"scikit-fuzzy", | ||
"sklearn", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"sklearn", | |
"scikit-learn", |
"sklearn", | ||
"statsmodels", | ||
"sympy", | ||
"tensorflow", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"tensorflow", | |
# "tensorflow", # Not yet compatible with Python 3.11 |
Describe your change:
Consolidate the requirements into
pyproject.toml
https://pip.pypa.io/en/stable/reference/build-system/pyproject-toml/
Checklist:
Fixes: #{$ISSUE_NO}
.