Skip to content

Add Cramer's rule for solving system of linear equations in two variables #7547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 25, 2022
Merged

Add Cramer's rule for solving system of linear equations in two variables #7547

merged 6 commits into from
Oct 25, 2022

Conversation

kituuu
Copy link
Contributor

@kituuu kituuu commented Oct 23, 2022 •
edited by cclauss
Loading

Describe your change:

Fixes #7122

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • [] Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added the require type hints https://docs.python.org/3/library/typing.html label Oct 23, 2022
algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 23, 2022
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 23, 2022
CaedenPH
CaedenPH requested changes Oct 23, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I think that raising a RuntimeError is better than returning a string error

@cclauss
Copy link
Member

cclauss commented Oct 23, 2022 •
edited
Loading

Let's use ValueError instead of RuntimeError because the problems are caused by the values of the input parameters.

@algorithms-keeper algorithms-keeper bot removed the require type hints https://docs.python.org/3/library/typing.html label Oct 23, 2022
@kituuu
Copy link
Contributor Author

kituuu commented Oct 23, 2022

Let's use ValueError instead of RuntimeError because the problems are caused by the values of the input parameters.

Okie, wait I am changing everything to ValueError, meanwhile can you also check my another PR #7355

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 23, 2022
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 23, 2022
@kituuu
Copy link
Contributor Author

kituuu commented Oct 23, 2022

@cclauss @CaedenPH Can you check now, any suggestions are welcomed. : D

@TheAlgorithms TheAlgorithms deleted a comment from CaedenPH Oct 23, 2022
@CaedenPH
Copy link
Contributor

@cclauss Do you know why my comment was deleted?

@cclauss
Copy link
Member

cclauss commented Oct 23, 2022

I do not want to remove else:.

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 23, 2022
cclauss
cclauss approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this one a lot! Thanks for your contribution.

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 23, 2022
@cclauss cclauss added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 23, 2022
poyea
poyea approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@poyea poyea changed the title added script for solving system of linear equations in two variables add Cramer's rule for solving system of linear equations in two variables Oct 25, 2022
@poyea poyea changed the title add Cramer's rule for solving system of linear equations in two variables Add Cramer's rule for solving system of linear equations in two variables Oct 25, 2022
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 25, 2022
@poyea poyea merged commit c3bcfbf into TheAlgorithms:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedenPH CaedenPH CaedenPH requested changes

@algorithms-keeper algorithms-keeper[bot] algorithms-keeper[bot] left review comments

@cclauss cclauss cclauss approved these changes

@poyea poyea poyea approved these changes

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System of linear equation in 2 variable.
4 participants
@kituuu @cclauss @CaedenPH @poyea