Skip to content

Fix Horn-Schunck depreciated namespace #7390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Fix Horn-Schunck depreciated namespace #7390

merged 2 commits into from
Oct 18, 2022

Conversation

tianyizheng02
Copy link
Contributor

@tianyizheng02 tianyizheng02 commented Oct 17, 2022

Describe your change:

Updated the namespace of convolve in computer_vision/horn_schunck.py from scipy.ndimage.filters to scipy.ndimage, as the former is depreciated (see the release notes for SciPy release 1.8.0 for more details).

Fixes #7299

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@tianyizheng02
Copy link
Contributor Author

@CaedenPH @cclauss Could one of you take a look to see if this solves the issue and is good for merging?

@cclauss
Copy link
Member

cclauss commented Oct 18, 2022

Please provide us a url to the docs that discuss the deprecation.

@tianyizheng02
Copy link
Contributor Author

tianyizheng02 commented Oct 18, 2022

@cclauss The release notes for SciPy 1.8.0 say the following:

In this release, all namespaces that were private but happened to miss underscores in their names have been deprecated. These include (as examples, there are many more):
- scipy.signal.spline
- scipy.ndimage.filters
...
All functions and other objects in these namespaces that were meant to be public are accessible from their respective public namespace

@cclauss cclauss merged commit 49cd46a into TheAlgorithms:master Oct 18, 2022
@cclauss cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PYTEST WARNING] Horn schunk
2 participants