Skip to content

refactor: move flake8 config #7167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2022
Merged

refactor: move flake8 config #7167

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41c0ea8
refactor: move flake8 config
dhruvmanila Oct 14, 2022
7955368
Update .pre-commit-config.yaml
cclauss Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .flake8
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
[flake8]
max-line-length = 88
max-complexity = 25
extend-ignore =
A003 # Class attribute is shadowing a python builtin
# Formatting style for `black`
E203 # Whitespace before ':'
W503 # Line break occurred before a binary operator
6 changes: 1 addition & 5 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@ repos:
rev: 5.0.4
hooks:
- id: flake8
args:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment on where to find the config settings.

- --ignore=E203,W503
- --max-complexity=25
- --max-line-length=88
additional_dependencies:
- flake8-bugbear
- flake8-builtins
Expand All @@ -51,7 +47,7 @@ repos:
- id: mypy
args:
- --ignore-missing-imports
- --install-types # See mirrors-mypy README.md
- --install-types # See mirrors-mypy README.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like two space much more. It visually separates the code from the comments

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's done by the formatter: https://github.com/redhat-developer/yaml-language-server

- --non-interactive
additional_dependencies: [types-requests]

Expand Down