-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
Add algorithm for Casimir Effect #7141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of passing 0
, how about all arguments are None
, and whichever argument isnt passed is evaluated. Otherwise, something may break if a legitimate value of a parameter is 0
In addition, instead of returning a dictionary of the missing value, you can just return the missing value
Hey @cclauss could you kindly take a look at the PR? |
physics/casimir_effect.py
Outdated
|
||
SPEED_OF_LIGHT = 3e8 # unit of c : m * s^-1 | ||
|
||
PI = 3.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from math import pi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
for more information, see https://pre-commit.ci
@cclauss Thanks for the suggestion! I used the module, and also updated the doc tests accordingly! |
Describe your change:
I implemented an algorithm to find out the magnitudes of either Force of attraction, distance or surface area of any of the two parallel plates in vacuum between which there is an existence of Casimir effect, using the general equation for Casimir effect, provided the values of the any of the two parameters are non-zero numbers.
Checklist:
Fixes: #{$ISSUE_NO}
.