Skip to content

Add typing to maths/sum_of_arithmetic_series.py #7065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2022
Merged

Add typing to maths/sum_of_arithmetic_series.py #7065

merged 1 commit into from
Oct 13, 2022

Conversation

saksham-chawla
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 12, 2022
@saksham-chawla saksham-chawla mentioned this pull request Oct 13, 2022
Merged
14 tasks
@saksham-chawla
Copy link
Contributor Author

cc: @cclauss

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 13, 2022
@cclauss cclauss merged commit c73cb7e into TheAlgorithms:master Oct 13, 2022
@cclauss
Copy link
Member

cclauss commented Oct 13, 2022 •
edited
Loading

Can we do lots of files in a single pull request? ~20 files max.

@saksham-chawla
Copy link
Contributor Author

@cclauss i would love that, however there is this checklist task - This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.

@saksham-chawla
Copy link
Contributor Author

@cclauss can you please add hacktoberfest lables?

@cclauss cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 13, 2022
@cclauss
Copy link
Member

cclauss commented Oct 13, 2022

I thought you only needed a handful to get the teeshirt / tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@CaedenPH CaedenPH CaedenPH approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
enhancement This PR modified some existing files hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saksham-chawla @cclauss @CaedenPH