-
-
Notifications
You must be signed in to change notification settings - Fork 46.8k
Add typing to data_structures/heap/heap_generic.py #7044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
87291d4
Update heap_generic.py
saksham-chawla 3079783
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1da74a6
Update heap_generic.py
saksham-chawla 38036b1
Update heap_generic.py
saksham-chawla b630168
Update heap_generic.py
saksham-chawla e1b9579
Update heap_generic.py
saksham-chawla 9eefc67
Update heap_generic.py
saksham-chawla b3a7617
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are really not needed. Both Python and mypy are able to figure this out without hinting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i got an error in pipeline without adding this: https://results.pre-commit.ci/run/github/63476337/1665575464.hZt5fgARRZacJLt5kikIdg @cclauss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cclauss if you are satisfied, can you please approve? i cannot open more PRs in the project since i have mutliple open - #7043 (comment)