Add Equal Loudness Filter

[Martmists-GH]

Describe your change:

Add an Equal Loudness Filter which aims to compensate for the human ear's non-linear response to sound. Based on the matlab implementation from hydrogenaudio (archive.org link)

Unfortunately the precommit hook really wants to format the frequencies and gains list in a very specific way, making it look awful.

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[algorithms-keeper]

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

• Contributing guidelines
• Project Euler solution guidelines

Python:

• Formatted string literals (f-strings)
• Type hints
• doctest
• unittest
• pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

---

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

• @algorithms-keeper review to trigger the checks for only added pull request files
• @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

[Martmists-GH]

@cclauss I applied your suggestions, would you happen to know why it's not working?

[algorithms-keeper]

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

• Contributing guidelines
• Project Euler solution guidelines

Python:

• Formatted string literals (f-strings)
• Type hints
• doctest
• unittest
• pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

---

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

• @algorithms-keeper review to trigger the checks for only added pull request files
• @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

[cclauss]

Nice! Thanks for doing this.

[cclauss]

@Martmists-GH Can you please rename
audio_filters/equal_loudness_filter.py.broken.txt --> audio_filters/equal_loudness_filter.py
and fix the failing test?

[Martmists-GH]

I'm not sure why it's failing, it was working fine when merged. Could you provide the error it gives?

[cclauss]

I bet it is a change in numpy...
https://numpy.org/doc/stable/reference/arrays.scalars.html#numpy.int_ with a trailing underscore.

=================================== FAILURES ===================================
__ [doctest] audio_filters.equal_loudness_filter.EqualLoudnessFilter.process ___
053 
054         Process a single sample through both filters
055 
056         >>> filt = EqualLoudnessFilter()
UNEXPECTED EXCEPTION: AttributeError("module 'numpy' has no attribute 'int'")
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.11.1/x64/lib/python3.11/doctest.py", line 1350, in __run
    exec(compile(example.source, filename, "single",
  File "<doctest audio_filters.equal_loudness_filter.EqualLoudnessFilter.process[0]>", line 1, in <module>
  File "/home/runner/work/Python/Python/audio_filters/equal_loudness_filter.py", line 49, in __init__
    ya, yb = yulewalk(10, freqs_normalized, gains_normalized)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.1/x64/lib/python3.11/site-packages/yulewalker/yulewalker.py", line 153, in yulewalk
    j = np.arange(nb, ne).astype(np.int)
                                 ^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.1/x64/lib/python3.11/site-packages/numpy/__init__.py", line 284, in __getattr__
    raise AttributeError("module {!r} has no attribute "
AttributeError: module 'numpy' has no attribute 'int'
/home/runner/work/Python/Python/audio_filters/equal_loudness_filter.py:56: UnexpectedException

[Martmists-GH]

It looks like the yulewalker package is not compatible with the new numpy version for 3.11, and you should open an issue on their repository instead.

[cclauss]

I think we did... mmxgn/yulewalker#5