Skip to content

Added mean absolute error in linear regression #7003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions machine_learning/linear_regression.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,19 @@ def run_linear_regression(data_x, data_y):
return theta


def mean_absolute_error(pred_X, org_X):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide more descriptive variable names and use snake_case

"""Return sum of square error for error calculation
:param pred_X : contains the output (result vector)
:param org_X : contains our dataset
:return : mean absolute error computed from given feature's
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as parameter names are more descriptive, the names should explain themselves

"""
total = 0
for i in range(len(org_X)):
total += abs(org_X[i] - pred_X[i])
error = sum / len(org_X)
return error


def main():
"""Driver function"""
data = collect_dataset()
Expand Down