-
-
Notifications
You must be signed in to change notification settings - Fork 46.9k
Added mean absolute error in linear regression #7003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cclauss
merged 7 commits into
TheAlgorithms:master
from
KushagraMakharia:AddMeanAbsoluteError_Regression
Oct 30, 2022
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5a30fec
Added mean absolute error in linear regression
KushagraMakharia ba8e5ca
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9396bac
Code feedback changes
KushagraMakharia a8c7f23
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b26c1ca
Apply suggestions from code review
cclauss 0c4487b
Apply suggestions from code review
cclauss aa0b4b7
Update linear_regression.py
cclauss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -87,6 +87,19 @@ def run_linear_regression(data_x, data_y): | |
return theta | ||
|
||
|
||
def mean_absolute_error(pred_X, org_X): | ||
"""Return sum of square error for error calculation | ||
:param pred_X : contains the output (result vector) | ||
:param org_X : contains our dataset | ||
:return : mean absolute error computed from given feature's | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As long as parameter names are more descriptive, the names should explain themselves |
||
""" | ||
total = 0 | ||
for i in range(len(org_X)): | ||
total += abs(org_X[i] - pred_X[i]) | ||
error = sum / len(org_X) | ||
return error | ||
|
||
|
||
def main(): | ||
"""Driver function""" | ||
data = collect_dataset() | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide more descriptive variable names and use
snake_case