Skip to content

improved implementation - all test passing now #6973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

improved implementation - all test passing now #6973

wants to merge 7 commits into from

Conversation

kituuu
Copy link
Contributor

@kituuu kituuu commented Oct 11, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

kituuu and others added 4 commits October 10, 2022 23:54
@kituuu
Modified - Matrix/inverse_of_matrix.py - added implementation for inv…
64cef2e 
…erse of 3x3 matrix
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
5818223 
for more information, see https://pre-commit.ci
@kituuu @pre-commit-ci
Modified matrix/inverse_of_matrix.py all test passing now
8afba69 
[pre-commit.ci] pre-commit autoupdate (#6940)

* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/psf/black: 22.8.0 → 22.10.0](psf/black@22.8.0...22.10.0)
- [github.com/asottile/pyupgrade: v2.38.2 → v3.0.0](asottile/pyupgrade@v2.38.2...v3.0.0)
- [github.com/pre-commit/mirrors-mypy: v0.981 → v0.982](pre-commit/mirrors-mypy@v0.981...v0.982)

* updating DIRECTORY.md

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@kituuu
Merge branch 'matrix3x3' of https://github.com/kituuu/Python into mat…
3e9e2f1 
…rix3x3
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 11, 2022
@cclauss
Copy link
Member

cclauss commented Oct 11, 2022

A machine does pre-commit autoupdate for us... #6940

cclauss
cclauss reviewed Oct 11, 2022
View reviewed changes
matrix/inverse_of_matrix.py
>>> inverse_of_matrix([[1, 2, 2], [1, 2, 2], [3, 2, -1]])
Traceback (most recent call last):
...
ValueError: This matrix has no inverse.
Copy link
Member

@cclauss cclauss Oct 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some more doctests:

>>> inverse_of_matrix([])
>>> inverse_of_matrix([1])
>>> inverse_of_matrix([[], []])
>>> inverse_of_matrix([[1, 2], [3, 4], [5, 6]])
>>> inverse_of_matrix([[1, 2, 3], [4, 5, 6]])

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sir, I am adding

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done sir

@dhruvmanila
Copy link
Member

@algorithms-keeper review-all

If possible, please fix them.

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 11, 2022
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 11, 2022
@kituuu kituuu requested review from cclauss and removed request for dhruvmanila October 11, 2022 13:28
@kituuu kituuu closed this Oct 17, 2022
@kituuu kituuu deleted the matrix3x3 branch October 17, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss Awaiting requested review from cclauss cclauss is a code owner

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kituuu @cclauss @dhruvmanila