Skip to content

Added spheres union #6879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Oct 27, 2022
Merged

Added spheres union #6879

merged 26 commits into from
Oct 27, 2022

Conversation

matteomessmer
Copy link
Contributor

My change

Added the algorithm for calculating the volume of spheres union.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 9, 2022
@matteomessmer
Copy link
Contributor Author

@Kush1101 do you have any update on my PR?

@CaedenPH
Copy link
Contributor

@Kush1101 do you have any update on my PR?

Kush seems to be an inactive user

CaedenPH
CaedenPH requested changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I preferred the f-strings, but everything else seems good

@matteomessmer
Copy link
Contributor Author

@CaedenPH oh my mistake, another PR changed the strings and I overwrote that with the previous version

@matteomessmer matteomessmer mentioned this pull request Oct 27, 2022
Merged
14 tasks
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 27, 2022
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 27, 2022
@matteomessmer
Copy link
Contributor Author

@cclauss I fixed some stuff and added more test

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 27, 2022
@cclauss cclauss merged commit 71e8ed8 into TheAlgorithms:master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedenPH CaedenPH CaedenPH requested changes

@cclauss cclauss cclauss approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteomessmer @CaedenPH @cclauss