Python program for Carmicheal Number #6864

Roy-Shubhajit · 2022-10-09T06:53:34Z

Describe your change:

Added Python Program for checking whether a number is Carmicheal number or not.

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

Python program to determine whether a number is Carmichael Number or not.

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

maths/carmichael_number.py

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

maths/carmichael_number.py

cclauss · 2022-10-09T07:35:07Z

maths/carmichael_number.py:3:89: E501 line too long (104 > 88 characters)
maths/carmichael_number.py:48:89: E501 line too long (89 > 88 characters)

maths/carmichael_number.py

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

maths/carmichael_number.py

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

maths/carmichael_number.py

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

maths/carmichael_number.py

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

maths/carmichael_number.py

Roy-Shubhajit · 2022-10-12T06:37:02Z

Hey @cclauss, can you please review this pull request for Hacktoberfest.

CaedenPH

Please write doctests for your functions

maths/carmichael_number.py

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2022-10-12T07:21:37Z

maths/carmichael_number.py

+"""
+
+
+def gcd(a: int, b: int) -> int:


As there is no test file in this pull request nor any test function or class in the file maths/carmichael_number.py, please provide doctest for the function gcd

Please provide descriptive name for the parameter: a

Please provide descriptive name for the parameter: b

algorithms-keeper · 2022-10-12T07:21:37Z

maths/carmichael_number.py

+    return gcd(b, a % b)
+
+
+def power(x: int, y: int, mod: int) -> int:


As there is no test file in this pull request nor any test function or class in the file maths/carmichael_number.py, please provide doctest for the function power

Please provide descriptive name for the parameter: x

Please provide descriptive name for the parameter: y

algorithms-keeper · 2022-10-12T07:21:37Z

maths/carmichael_number.py

+    return temp
+
+
+def isCarmichaelNumber(n: int) -> bool:


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: isCarmichaelNumber

As there is no test file in this pull request nor any test function or class in the file maths/carmichael_number.py, please provide doctest for the function isCarmichaelNumber

Please provide descriptive name for the parameter: n

CaedenPH · 2022-10-12T10:45:55Z

@cclauss
Why have you merged this commit? It didn't even pass the CONTRIBUTING guidelines such as snake_case naming conventions and informative parameter names

cclauss · 2022-10-12T10:48:21Z

Yes. I saw that as I pressed the Merge button. If you open a PR to fix that then I will merge it.

cclauss · 2022-10-12T10:50:50Z

In fact, we should probably add a good flake8 naming plugin to pre-commit so that our tests fail on bad names.

https://github.com/DmytroLitvinov/awesome-flake8-extensions#naming

Your thoughts?

CaedenPH · 2022-10-12T10:52:54Z

In fact, we should probably add a good flake8 naming plugin to pre-commit so that our tests fail on bad names.

https://github.com/DmytroLitvinov/awesome-flake8-extensions#naming

Your thoughts?

Sounds like a good idea

cclauss · 2022-10-12T11:05:07Z

Do you have pre-commit running on your local machine?

Would you be willing to make the following one-line change to .pre-commit-config.yaml and then fix the files that will be flagged by running pre-commit run --all-files? It is a bit of busy-work that will take some time but it will be a nice improvement to our project.

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 0abe647..2f6a928 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -40,6 +40,7 @@ repos:
           - --ignore=E203,W503
           - --max-complexity=25
           - --max-line-length=88
+        additional_dependencies: [pep8-naming]

   - repo: https://github.com/pre-commit/mirrors-mypy
     rev: v0.982

CaedenPH · 2022-10-12T11:10:52Z

Do you have pre-commit running on your local machine?

Would you be willing to make the following one-line change to .pre-commit-config.yaml and then fix the files that will be flagged by running pre-commit run --all-files? It is a bit of busy-work that will take some time but it will be a nice improvement to our project.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 0abe647..2f6a928 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -40,6 +40,7 @@ repos:
           - --ignore=E203,W503
           - --max-complexity=25
           - --max-line-length=88
+        additional_dependencies: [pep8-naming]

   - repo: https://github.com/pre-commit/mirrors-mypy
     rev: v0.982

Unfortunately I am not at home currently, but I can do it in a couple hours when I return

cclauss · 2022-10-12T11:16:26Z

No rush!

Roy-Shubhajit added 3 commits October 9, 2022 12:12

Add files via upload

ef152c8

Python program to determine whether a number is Carmichael Number or not.

Rename Carmichael Number.py to carmichael number.py

73de0dc

Rename carmichael number.py to carmichael_number.py

26effa4

Roy-Shubhajit requested a review from Kush1101 as a code owner October 9, 2022 06:53

algorithms-keeper bot added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 9, 2022

algorithms-keeper bot reviewed Oct 9, 2022

View reviewed changes

maths/carmichael_number.py Outdated Show resolved Hide resolved

maths/carmichael_number.py Outdated Show resolved Hide resolved

maths/carmichael_number.py Outdated Show resolved Hide resolved

algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 9, 2022

[pre-commit.ci] auto fixes from pre-commit.com hooks

35ced94

for more information, see https://pre-commit.ci

algorithms-keeper bot reviewed Oct 9, 2022

View reviewed changes

maths/carmichael_number.py Outdated Show resolved Hide resolved

maths/carmichael_number.py Outdated Show resolved Hide resolved

maths/carmichael_number.py Outdated Show resolved Hide resolved

cclauss reviewed Oct 9, 2022

View reviewed changes

maths/carmichael_number.py Outdated Show resolved Hide resolved

cclauss reviewed Oct 9, 2022

View reviewed changes

maths/carmichael_number.py Outdated Show resolved Hide resolved

cclauss reviewed Oct 9, 2022

View reviewed changes

maths/carmichael_number.py Outdated Show resolved Hide resolved

Update carmichael_number.py

5c6365f

algorithms-keeper bot removed require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 9, 2022

algorithms-keeper bot reviewed Oct 9, 2022

View reviewed changes

maths/carmichael_number.py Outdated Show resolved Hide resolved

[pre-commit.ci] auto fixes from pre-commit.com hooks

1531bf3

for more information, see https://pre-commit.ci

algorithms-keeper bot reviewed Oct 9, 2022

View reviewed changes

maths/carmichael_number.py Outdated Show resolved Hide resolved

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 9, 2022

Create carmichael_number.py

d3ab156

algorithms-keeper bot added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required labels Oct 9, 2022

algorithms-keeper bot reviewed Oct 9, 2022

View reviewed changes

maths/carmichael_number.py Show resolved Hide resolved

maths/carmichael_number.py Show resolved Hide resolved

maths/carmichael_number.py Show resolved Hide resolved

[pre-commit.ci] auto fixes from pre-commit.com hooks

0a39468

for more information, see https://pre-commit.ci

algorithms-keeper bot reviewed Oct 9, 2022

View reviewed changes

maths/carmichael_number.py Show resolved Hide resolved

maths/carmichael_number.py Show resolved Hide resolved

maths/carmichael_number.py Show resolved Hide resolved

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 9, 2022

Roy-Shubhajit requested review from cclauss and removed request for Kush1101 October 9, 2022 09:53

CaedenPH requested changes Oct 12, 2022

View reviewed changes

cclauss reviewed Oct 12, 2022

View reviewed changes

maths/carmichael_number.py Outdated Show resolved Hide resolved

Update maths/carmichael_number.py

2dd3e39

cclauss approved these changes Oct 12, 2022

View reviewed changes

algorithms-keeper bot reviewed Oct 12, 2022

View reviewed changes

algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 12, 2022

cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 12, 2022

cclauss merged commit f0d1a42 into TheAlgorithms:master Oct 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Python program for Carmicheal Number #6864

Python program for Carmicheal Number #6864

Roy-Shubhajit commented Oct 9, 2022 •

edited

Loading

algorithms-keeper bot left a comment

algorithms-keeper bot left a comment

cclauss commented Oct 9, 2022

algorithms-keeper bot left a comment

algorithms-keeper bot left a comment

algorithms-keeper bot left a comment

algorithms-keeper bot left a comment

Roy-Shubhajit commented Oct 12, 2022

CaedenPH left a comment

algorithms-keeper bot left a comment

algorithms-keeper bot Oct 12, 2022

algorithms-keeper bot Oct 12, 2022

algorithms-keeper bot Oct 12, 2022

CaedenPH commented Oct 12, 2022

cclauss commented Oct 12, 2022

cclauss commented Oct 12, 2022 •

edited

Loading

CaedenPH commented Oct 12, 2022

cclauss commented Oct 12, 2022

CaedenPH commented Oct 12, 2022

cclauss commented Oct 12, 2022

		return gcd(b, a % b)


		def power(x: int, y: int, mod: int) -> int:

Python program for Carmicheal Number #6864

Python program for Carmicheal Number #6864

Conversation

Roy-Shubhajit commented Oct 9, 2022 • edited Loading

Describe your change:

Checklist:

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

cclauss commented Oct 9, 2022

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Roy-Shubhajit commented Oct 12, 2022

CaedenPH left a comment

Choose a reason for hiding this comment

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot Oct 12, 2022

Choose a reason for hiding this comment

algorithms-keeper bot Oct 12, 2022

Choose a reason for hiding this comment

algorithms-keeper bot Oct 12, 2022

Choose a reason for hiding this comment

CaedenPH commented Oct 12, 2022

cclauss commented Oct 12, 2022

cclauss commented Oct 12, 2022 • edited Loading

CaedenPH commented Oct 12, 2022

cclauss commented Oct 12, 2022

CaedenPH commented Oct 12, 2022

cclauss commented Oct 12, 2022

Roy-Shubhajit commented Oct 9, 2022 •

edited

Loading

cclauss commented Oct 12, 2022 •

edited

Loading