Skip to content

create quantum_fourier_transform #6682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 31, 2022
Merged

create quantum_fourier_transform #6682

merged 8 commits into from
Oct 31, 2022

Conversation

KevinJoven11
Copy link
Contributor

This is part of the #Hacktoberfest.
I build the quantum fourier transform for N qubits. (n = 3 in the example) Best,
Kevin

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@KevinJoven11
create quantum_fourier_transform
ba5499f 
This is part of the #Hacktoberfest.
I build the quantum fourier transform for N qubits. (n = 3 in the example)
Best,
Kevin
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required labels Oct 5, 2022
algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 5, 2022
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 5, 2022
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@algorithms-keeper algorithms-keeper bot mentioned this pull request Oct 7, 2022
Closed
14 tasks
@KevinJoven11
Copy link
Contributor Author

@cclauss Hi! Sorry for ping you. I just wanna know if this repo (Algorithms/Python) is not more part of the #Hacktoberfest or is there another reason for that. I just wanna have my second contribution to the hackfest to have the t-shirt.
Best,

@cclauss cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 15, 2022
@cclauss
Copy link
Member

cclauss commented Oct 15, 2022 •
edited
Loading

We had a handful of pull requests when October started and we have almost 200 now so I view Hacktoberfest to be a bit of a denial of service attack on my productivity but we do give out the labels (added here) for pull requests that meet out CONTRIBUTING.md requirements.

A function name like qft() is not self-documenting. Also we require doctests.

cclauss
cclauss reviewed Oct 15, 2022
View reviewed changes
quantum/q_fourier_transform.py Outdated
from qiskit import Aer, ClassicalRegister, QuantumCircuit, QuantumRegister, execute


def qft(n: int = 3) -> qiskit.result.counts.Counts:
Copy link
Member

@cclauss cclauss Oct 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def qft(n: int = 3) -> qiskit.result.counts.Counts:
def quantum_fourier_transform(number_of_qubits: int = 3) -> qiskit.result.counts.Counts:

@cclauss
Copy link
Member

cclauss commented Oct 15, 2022

Extra credit: In a separate pull request, fix the PendingDeprecationWarning that pytest is raising in our automated testing… https://github.com/TheAlgorithms/Python/actions/runs/3254565205/jobs/5342967879#step:6:644

@algorithms-keeper algorithms-keeper bot removed the require descriptive names This PR needs descriptive function and/or variable names label Oct 15, 2022
algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 15, 2022
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@algorithms-keeper algorithms-keeper bot removed the require tests Tests [doctest/unittest/pytest] are required label Oct 15, 2022
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 15, 2022
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 15, 2022
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 15, 2022
@cclauss cclauss merged commit 21601a4 into TheAlgorithms:master Oct 31, 2022
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algorithms-keeper algorithms-keeper[bot] algorithms-keeper[bot] left review comments

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinJoven11 @cclauss