Skip to content

Add print_multiplication_table.py #6607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 30, 2022
Merged
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions maths/print_multiplication_table.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
def print_multiplication_table(number: int, number_of_terms: int) -> None:
Copy link
Member

@cclauss cclauss Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algorithmic functions should not print(). So, instead of printing the results, this function should return a multi line string to the caller of the function. The caller can then choose to print that string, put it in an email, or tweet it, etc.

Suggested change
def print_multiplication_table(number: int, number_of_terms: int) -> None:
def multiplication_table(number: int, number_of_terms: int) -> str:

"""
Prints the multiplication table of a given number till the given number of terms
>>> print_multiplication_table(3,5)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
>>> print_multiplication_table(3,5)
>>> print_multiplication_table(3, 5)

3 * 1 = 3
3 * 2 = 6
3 * 3 = 9
3 * 4 = 12
3 * 5 = 15

>>> print_multiplication_table(-4,6)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
>>> print_multiplication_table(-4,6)
>>> print_multiplication_table(-4, 6)

-4 * 1 = -4
-4 * 2 = -8
-4 * 3 = -12
-4 * 4 = -16
-4 * 5 = -20
-4 * 6 = -24
"""
for i in range(1, number_of_terms + 1):
print(f"{number} * {i} = " + str(number * i))
Copy link
Member

@cclauss cclauss Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print(f"{number} * {i} = " + str(number * i))
print(f"{number} * {i} = {number * i}")

Copy link
Contributor

@CaedenPH CaedenPH Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss You have used mobile quotes here, . You need to use "

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thx.



if __name__ == "__main__":
number = 5
number_of_terms = 10
print_multiplication_table(number, number_of_terms)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the two previous lines.

Suggested change
print_multiplication_table(number, number_of_terms)
print_multiplication_table(number=5, number_of_terms=10)