Skip to content

feat(maths): add function to perform calculation #6602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 27, 2023
Merged

feat(maths): add function to perform calculation #6602

merged 7 commits into from
Sep 27, 2023

Conversation

okzapradhana
Copy link
Contributor

Describe your change:

  • Add single function to calculate sum of two positive numbers using bitwise operator
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Okza Pradhana added 2 commits October 3, 2022 17:58
feat(maths): add function to perform calculation
3ffc115 
- Add single function to calculate sum of two positive numbers
  using bitwise operator
docs: add wikipedia url as explanation
82ffd35
@okzapradhana okzapradhana requested a review from Kush1101 as a code owner October 3, 2022 10:04
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 3, 2022
CaedenPH
CaedenPH approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tianyizheng02 Pinging for review. Looks mostly good to me

@CaedenPH
Copy link
Contributor

Correction. This algorithm should be in the bit_manipulation folder
@okzapradhana Can you move it there please?
(https://github.com/TheAlgorithms/Python/tree/master/bit_manipulation)

tianyizheng02
tianyizheng02 requested changes Aug 21, 2023
View reviewed changes
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Sep 27, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Sep 27, 2023
tianyizheng02
tianyizheng02 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CaedenPH Since we can't expect the author to respond to this PR anymore, I'll just accept this (fixed) PR and open a new PR to move this file to the correct directory myself.

@tianyizheng02 tianyizheng02 merged commit b2e186f into TheAlgorithms:master Sep 27, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Sep 27, 2023
@tianyizheng02 tianyizheng02 mentioned this pull request Sep 27, 2023
Merged
14 tasks
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@okzapradhana @pre-commit-ci
@tianyizheng02 @CaedenPH @sedatguzelsemme
feat(maths): add function to perform calculation (TheAlgorithms#6602)
e9aee30 
* feat(maths): add function to perform calculation
- Add single function to calculate sum of two positive numbers
  using bitwise operator

* docs: add wikipedia url as explanation

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: Caeden Perelli-Harris <[email protected]>

* Update sum_of_two_positive_numbers_bitwise.py

* Update sum_of_two_positive_numbers_bitwise.py

* Update sum_of_two_positive_numbers_bitwise.py

---------

Co-authored-by: Okza Pradhana <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tianyi Zheng <[email protected]>
Co-authored-by: Caeden Perelli-Harris <[email protected]>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedenPH CaedenPH CaedenPH approved these changes

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@okzapradhana @CaedenPH @tianyizheng02