Created a file revere linked list #6592
Conversation
This program mainly does is it reverse the linked list given to us with the time complexity of O(n) and Space complexity of O(n).
algorithms-keeper
bot
added
awaiting reviews
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
RevrseLinkedList.py
Outdated
| class Node: | ||
|
|
||
| # Constructor to initialize the node object | ||
| def __init__(self, data): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: data
RevrseLinkedList.py
Outdated
| class LinkedList: | ||
|
|
||
| # Function to initialize head | ||
| def __init__(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
RevrseLinkedList.py
Outdated
| self.head = None | ||
|
|
||
| # Function to reverse the linked list | ||
| def reverse(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: reverse. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file RevrseLinkedList.py, please provide doctest for the function reverse
RevrseLinkedList.py
Outdated
| self.head = prev | ||
|
|
||
| # Function to insert a new node at the beginning | ||
| def push(self, new_data): |
There was a problem hiding this comment.
Please provide return type hint for the function: push. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file RevrseLinkedList.py, please provide doctest for the function push
Please provide type hint for the parameter: new_data
RevrseLinkedList.py
Outdated
| self.head = new_node | ||
|
|
||
| # Utility function to print the LinkedList | ||
| def printList(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: printList. If the function does not return a value, please provide the type hint as: def function() -> None:
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: printList
As there is no test file in this pull request nor any test function or class in the file RevrseLinkedList.py, please provide doctest for the function printList
|
|
||
|
|
||
| # Driver program to test above functions | ||
| def main(): |
There was a problem hiding this comment.
Please provide return type hint for the function: main. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file RevrseLinkedList.py, please provide doctest for the function main
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| class Node: | ||
|
|
||
| # Constructor to initialize the node object | ||
| def __init__(self, data): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: data
| class LinkedList: | ||
|
|
||
| # Function to initialize head | ||
| def __init__(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| self.head = None | ||
|
|
||
| # Function to reverse the linked list | ||
| def reverse(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: reverse. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file RevrseLinkedList.py, please provide doctest for the function reverse
| self.head = prev | ||
|
|
||
| # Function to insert a new node at the beginning | ||
| def push(self, new_data): |
There was a problem hiding this comment.
Please provide return type hint for the function: push. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file RevrseLinkedList.py, please provide doctest for the function push
Please provide type hint for the parameter: new_data
| self.head = new_node | ||
|
|
||
| # Utility function to print the LinkedList | ||
| def printList(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: printList. If the function does not return a value, please provide the type hint as: def function() -> None:
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: printList
As there is no test file in this pull request nor any test function or class in the file RevrseLinkedList.py, please provide doctest for the function printList
|
|
||
|
|
||
| # Driver program to test above functions | ||
| def main(): |
There was a problem hiding this comment.
Please provide return type hint for the function: main. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file RevrseLinkedList.py, please provide doctest for the function main
This program mainly does is it reverse the linked list given to us with the time complexity of O(n) and Space complexity of O(n).
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.