Skip to content

Add missing type hints in matrix directory #6409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

Add missing type hints in matrix directory #6409

wants to merge 14 commits into from

Conversation

rohanr18
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Sep 30, 2022
CaedenPH
CaedenPH reviewed Sep 30, 2022
View reviewed changes
@dhruvmanila dhruvmanila self-assigned this Oct 1, 2022
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 1, 2022
@cclauss
Copy link
Member

cclauss commented Oct 1, 2022

In preparation for that denial-of-service attack that is Hacktoberfest, I am closing all pull requests that have failing tests.

@cclauss cclauss closed this Oct 1, 2022
@rohanr18
Copy link
Contributor Author

rohanr18 commented Oct 1, 2022

@cclauss @dhruvmanila
I've changed 8 files, and there's an error with 1. Can this be reopened?

@rohanr18
Copy link
Contributor Author

rohanr18 commented Oct 3, 2022

@cclauss @dhruvmanila
Please reopen

@dhruvmanila
Copy link
Member

Could you please create another PR? Sorry for the inconvenience caused.

@rohanr18 rohanr18 mentioned this pull request Oct 3, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedenPH CaedenPH CaedenPH left review comments

@dhruvmanila dhruvmanila dhruvmanila left review comments

Assignees

@dhruvmanila dhruvmanila

Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rohanr18 @cclauss @dhruvmanila @CaedenPH