Skip to content

Fix Max Fenwick Tree #6328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2022
Merged

Fix Max Fenwick Tree #6328

merged 1 commit into from
Sep 14, 2022

Conversation

C21-github
Copy link
Contributor

Describe your change:

And test for bugs in Max Fenwick Tree and modifications to fix them.

Using 1-based-indexing operations: (index | (index + 1)) for a 0-based fenwick tree requires handling edge cases and is the cause for the bugs. Replacing with 0-based-indexing operations.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Aug 15, 2022
@C21-github
Copy link
Contributor Author

@cclauss can you please take a look

poyea
poyea approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@poyea poyea merged commit 81e30fd into TheAlgorithms:master Sep 14, 2022
@algorithms-keeper algorithms-keeper bot removed awaiting reviews This PR is ready to be reviewed labels Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsamirhn itsamirhn itsamirhn approved these changes

@poyea poyea poyea approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@C21-github @itsamirhn @poyea