Skip to content

Fenwick Tree #6319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 16, 2022
Merged

Fenwick Tree #6319

merged 14 commits into from
Aug 16, 2022

Conversation

itsamirhn
Copy link
Member

Describe your change:

I added rank_query algorithm to FenwickTree and some other implementations such as getting array of tree or building tree in O(n) time. Also I added doctests to all methods.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Aug 12, 2022
@ghost ghost mentioned this pull request Aug 12, 2022
Closed
14 tasks
@ghost ghost added the tests are failing Do not merge until tests pass label Aug 13, 2022
@itsamirhn
Copy link
Member Author

@cclauss, Thanks for your suggestions!

@ghost ghost removed the tests are failing Do not merge until tests pass label Aug 13, 2022
poyea
poyea approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Aug 16, 2022
@poyea poyea added the awaiting merge This PR is approved and ready to be merged label Aug 16, 2022
@ghost ghost removed the awaiting merge This PR is approved and ready to be merged label Aug 16, 2022
@cclauss cclauss merged commit f31fa4e into TheAlgorithms:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@poyea poyea poyea approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itsamirhn @cclauss @poyea