Add Max Fenwick Tree #6298
Add Max Fenwick Tree #6298
Conversation
ghost
added
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
ghost
removed
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
ghost
removed
the
require descriptive names
…ck-tree # Conflicts: # data_structures/binary_tree/maximum_fenwick_tree_one_based_indexig.py
|
@cclauss Let me now if these changes solves the issues that you commented. |
|
Why is one-based indexing an advantage in a language that uses zero-based indexing? |
|
The one-based indexing is default for any Fenwick Tree. In all languages we use one-based indexing because of the main theory idea behind Fenwick tree that is Even in the previous implementation of Fenwick Tree in this repository (here), we had to used one-based by default. But there is another tricky way to solve the one-based indexing issue as Wikipedia has used too. I can add the zero-based indexing too if you want. |
|
@cclauss, I changed the tree into 0-based indexing. |
Describe your change:
I created MaxFenwickTreeOneBasedIndexing wich solves this problem:
This algorithm use classic fenwick tree with some changes in key ideas.
Checklist:
Fixes: #{$ISSUE_NO}.