Skip to content

feat: add Project Euler problem 073 solution 1 #6273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 24, 2022
Merged

feat: add Project Euler problem 073 solution 1 #6273

merged 6 commits into from
Oct 24, 2022

Conversation

MaximSmolskiy
Copy link
Member

Describe your change:

Add Project Euler problem 073 solution 1:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Jul 26, 2022
@ghost ghost mentioned this pull request Jul 29, 2022
Closed
14 tasks
@MaximSmolskiy
Copy link
Member Author

@cclauss @dhruvmanila please review

@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 24, 2022
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 24, 2022
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 24, 2022
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 24, 2022
@MaximSmolskiy MaximSmolskiy requested review from dhruvmanila and removed request for Kush1101 October 24, 2022 11:18
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 24, 2022
@dhruvmanila dhruvmanila changed the title Add Project Euler problem 073 solution 1 feat: add Project Euler problem 073 solution 1 Oct 24, 2022
@dhruvmanila dhruvmanila merged commit a041b64 into TheAlgorithms:master Oct 24, 2022
@MaximSmolskiy MaximSmolskiy deleted the add-project-euler-problem-073-solution-1 branch October 24, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaximSmolskiy @dhruvmanila