Skip to content

Get rid of the Union #6246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 11, 2022
Merged

Get rid of the Union #6246

merged 4 commits into from
Jul 11, 2022

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Jul 11, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jul 11, 2022
@cclauss cclauss requested a review from poyea July 11, 2022 10:58
poyea
poyea approved these changes Jul 11, 2022
View reviewed changes
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jul 11, 2022
@ghost ghost added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Jul 11, 2022
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jul 11, 2022
@cclauss
Copy link
Member Author

cclauss commented Jul 11, 2022

Do you know how we can enable https://pre-commit.ci on this repo? That would automate a lot of busy work.

@ghost ghost removed the tests are failing Do not merge until tests pass label Jul 11, 2022
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Jul 11, 2022
@poyea
Copy link
Member

poyea commented Jul 11, 2022

Should we request it on the website?

@poyea
Copy link
Member

poyea commented Jul 11, 2022

I made a request - not sure where it will be routed to

@cclauss cclauss merged commit dad789d into master Jul 11, 2022
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jul 11, 2022
@cclauss cclauss deleted the Get-rid-of-the-Union branch July 11, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @poyea