Skip to content

Fix doctests and builds in various files #6233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 6, 2022
Merged

Fix doctests and builds in various files #6233

merged 4 commits into from
Jul 6, 2022

Conversation

poyea
Copy link
Member

@poyea poyea commented Jul 6, 2022 •
edited
Loading

Describe your change:

This fixes several doctest and typing issues, in 3 files to make the build pass.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jul 6, 2022
@poyea poyea requested a review from Panquesito7 July 6, 2022 07:33
@ghost ghost added the tests are failing Do not merge until tests pass label Jul 6, 2022
@ghost ghost removed the tests are failing Do not merge until tests pass label Jul 6, 2022
@poyea poyea changed the title Fix doctest in hamming distance Fix doctests and builds in various files Jul 6, 2022
@poyea poyea requested a review from cclauss July 6, 2022 07:57
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jul 6, 2022
@cclauss cclauss merged commit 9135a1f into TheAlgorithms:master Jul 6, 2022
@poyea poyea deleted the fix-doctests branch July 6, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poyea @cclauss