absMax fix bug. #619
Closed
absMax fix bug. #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanglbme
reviewed
Dec 4, 2018
Maths/3n+1.py
Outdated
| """ | ||
| 算法题： | ||
|
|
||
| 输入一个数，偶数时则砍掉一半；奇数时，则（3n+1）砍掉一半，最后直到得到1.问，进行了多少次？ |
There was a problem hiding this comment.
嘿，哥儿们，国外仓库不要用中文噢~
Do not use Chinese characters, please :)
|
OK!Remove Chinese remarks.Done. And,absmax.py and absmin.py bugs fixed. I think absmax.py and absmin.py, are the Numbers with the max output absolute value and the min output absolute value.please check pull request #623. |
|
my version output example : absMax.py【a = [-13, 2, -11, -12] print(absMax(a)) # = -13】， this absMax print -13 ; absMin.py【 a = [-3,-1,2,-11] print(absMin(a)) # = -1】， this absMin print -1 . please check it. |
|
Write your commit messages in English, please! 哥儿们，你用中文写提交信息，我要是 考虑把这个 pr 关了，你重新提交个规范的，我再 Review 一下~ thx :) |
|
this is my first pr.Sorry,ok,i do it right now.thx:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
absMax fix bug.And in absMin.py,
import error,fix it.just make it better.