Skip to content

Improve Project Euler problem 145 solution 1 #6141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MaximSmolskiy
Copy link
Member

@MaximSmolskiy MaximSmolskiy commented May 12, 2022

Describe your change:

Improve Project Euler problem 145 solution 1 - the top 1 slowest solution on GitHub Actions logs (under slowest 10 durations: 913.91s call scripts/validate_solutions.py::test_project_euler[problem_145/sol1.py]):

  • Improve solution (~1.3 times - from 900+ seconds to ~700 seconds)

  • Add an algorithm?

  • Fix a bug or typo in an existing algorithm?

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels May 12, 2022
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label May 24, 2022
@poyea poyea merged commit de4d980 into TheAlgorithms:master May 24, 2022
@MaximSmolskiy MaximSmolskiy deleted the improve-project-euler-problem-145-solution-1 branch May 26, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants