Skip to content

feat: added ngram algorithm #6074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 4, 2022
Merged

feat: added ngram algorithm #6074

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ffaeb26
feat: added ngram algorithm
9harshit Mar 29, 2022
e3a4b20
feat: added ngram algorithm
9harshit Mar 29, 2022
4541ff8
feat: added ngram algorithm
9harshit Mar 29, 2022
8786649
Merge branch 'TheAlgorithms:master' into master
9harshit Mar 30, 2022
1f237cd
added list comprehension
9harshit Mar 30, 2022
2bf6ea8
Update strings/ngram.py
9harshit Mar 30, 2022
988fdda
Update strings/ngram.py
9harshit Mar 30, 2022
a4e5d83
Update strings/ngram.py
9harshit Mar 31, 2022
e8b19a4
Update ngram.py
9harshit Mar 31, 2022
c0c5d01
chore: add return list element type
dhruvmanila Apr 4, 2022
43be367
fix(test): use `round` to match approx for float
dhruvmanila Apr 4, 2022
369a790
fix: round down one more digit
dhruvmanila Apr 4, 2022
f69589e
chore: use math.isclose instead of round
dhruvmanila Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions strings/ngram.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ def create_ngram(sentence: str, ngram_size: int) -> list:
['I ', ' a', 'am', 'm ', ' a', 'an', 'n ', ' N', 'NL', 'LP', 'Pe', 'er']
"""

ngrams = []
for i in range(len(sentence) - ngram_size + 1):
ngrams.append(sentence[i : i + ngram_size])
ngrams = [
sentence[i : i + ngram_size] for i in range(len(sentence) - ngram_size + 1)
]
return ngrams


Expand Down